This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
DOP-1160: adds deploy stage to world builder, updates list of projects #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmalliso
commented
Jun 3, 2020
| print('Failed to build in {}'.format(task.build_dir)) | ||
| build_errors.append(task.build_dir) | ||
| print("Failed to build in {}".format(task.build_dir)) | ||
| tasks.remove(task) # so that we don't deploy the unbuilt thing |
There was a problem hiding this comment.
I'm not confident this is actually the right way to handle this…
i80and
approved these changes
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I ran the linter/formatter, so it looks like I've been REAL PRODUCTIVE.
I tested it with a snippets-test.json that had the info for docs-compass, swapping
make deployformake stagelest I ruin everything, and it worked a charm!